• rglullis@communick.newsOP
    link
    fedilink
    English
    arrow-up
    2
    arrow-down
    6
    ·
    1 year ago

    The author ended up creating a strawman. Allen’s argument was pretty clear: if your deltas are small and your deploy system is fully automated, then no one should be afraid of the risk of deploying.

    Given that, if I deploy on a Monday morning and there is a bug on the new release, you revert, reproduce the issue in staging and push only new code when it is fixed. Same thing if I were deploying on a Thursday afternoon or a Friday at 7PM.

    • MajorHavoc@lemmy.world
      link
      fedilink
      arrow-up
      9
      ·
      1 year ago

      Only inexperienced developers* are unafraid of deploying right before leaving the office.

      There’s an entire untapped universe of possible new ways that things can go horribly wrong.

      *Experienced developers who hate their boss and their colleagues, too, technically.

            • MajorHavoc@lemmy.world
              link
              fedilink
              arrow-up
              4
              ·
              1 year ago

              It’s not about how hard the problem is to reverse, it’s about respecting the team enough not to call them on Saturday.

              • rglullis@communick.newsOP
                link
                fedilink
                English
                arrow-up
                1
                arrow-down
                4
                ·
                edit-2
                1 year ago

                Again: if the changes are small enough and you have automated checks in place, they should not require manual intervention.

                Plus, what happens if a deploy on Thursday has a bug which only is manifested on a Saturday?

                • MajorHavoc@lemmy.world
                  link
                  fedilink
                  arrow-up
                  7
                  ·
                  1 year ago

                  Again: if the changes are small enough and you have automated checks in place, they should not require manual intervention.

                  You’ve used the magic word “should”. “Should is famous last words.” The trick to keeping developer talent is not to risk the developer’s weekend plans on “should”.

                  And yes, maybe I’m only risking our cloud ops person’s weekend plans. Same principle applies.

                  Every change that isn’t already an active disaster recovery can wait for Monday.

                  • rglullis@communick.newsOP
                    link
                    fedilink
                    English
                    arrow-up
                    1
                    arrow-down
                    3
                    ·
                    1 year ago

                    Every change that isn’t already an active disaster recovery can wait for Monday.

                    I honestly fail to see the difference between “don’t deploy on Friday if this can wait until Monday” and “don’t deploy on the evening if it can wait until the next morning”.

                    The idea of CD is that changes are small and cheap. No one is saying “it’s okay to push huge PRs with huge database migrations on a Friday”, what is being said is “if your team is used to ship frequently and incrementally, it won’t matter when you ship and your risk will always be small.”

                • MajorHavoc@lemmy.world
                  link
                  fedilink
                  arrow-up
                  5
                  ·
                  1 year ago

                  Good question.

                  Since we’re doing a deep dive, I’ll share some additonal context. I’m the manager of the developers. On my team, that means the call comes to me first.

                  I have had Thursday deploys that resulted in bugs discovered on Saturday. Here’s how the conversation on Saturday went:

                  “Thanks for letting me know. So we didn’t notice this on Friday?”

                  “No, it’s subtle.” Or “We noticed, but didn’t get around to letting you know until now.”

                  “Okay. I’ll let the team know to plan to rollback at 0900 on Monday, then we will start fixing any damage that happened on Friday, and the weekend.”